use user HOME dir for cache, config, models#253
Open
EricDeveaud wants to merge 3 commits intoRosettaCommons:mainfrom
Open
use user HOME dir for cache, config, models#253EricDeveaud wants to merge 3 commits intoRosettaCommons:mainfrom
EricDeveaud wants to merge 3 commits intoRosettaCommons:mainfrom
Conversation
…es, config location and so on
models weight directory may be specified by RFD_MODELS en var.
hydra config location may be overwitten by RFD_HYDRA_CFG env var
Member
|
It might be better to use the user directory as a fall back. That is, instead of always writing to the user directory, only use the user directory if the installation directory isn't writable. Additionally, I would probably recommend using a "hidden" directory (i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #252
PR propose to have a
$HOME/rfdiffusionthat will hold all necessary files where write erpmission is required.with this PR:
$HOME/rfdiffusion/config/inference/$HOME/rfdiffusion/schedules$HOME/rfdiffusion/modelsfurthermore the PR allows weight models directory search to be overwritten by
RFD_MODELSenvironment variable.by default check in
$HOME/rfdiffusion/modelsand search$RFD_MODELSinstead if is defined(allow mutualisation of models on a shared cluster)
same for inference config files, if
RFD_HYDRA_CFGis defined.regards
Eric